ci: Add arm64 makefile targets. #1755
Open
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuabaird
commented
Oct 29, 2025
| apiVersion: v1 | ||
| fieldPath: metadata.namespace | ||
| image: ghcr.io/fluent/fluent-operator/fluent-operator:v3.5.0 | ||
| image: ghcr.io/fluent/fluent-operator/fluent-operator:latest |
There was a problem hiding this comment.
Unrelated, but this resets the tag to latest on master so that CI passes.
cw-Guo
previously approved these changes
Oct 30, 2025
marcofranssen
force-pushed
the
chore/arm64-makefile-targets
branch
from
9ab9746 to
e465c94
Compare
marcofranssen
requested changes
Oct 30, 2025
There was a problem hiding this comment.
See suggestions:
- Some targets where copy past errors and still amd64.
- PHONY should be used https://makefiletutorial.com/#phony
cw-Guo
reviewed
Oct 30, 2025
Makefile
Outdated
| docker buildx build --push --platform linux/amd64,linux/arm64 -f cmd/fluent-watcher/fluentbit/Dockerfile.debug . -t ${FB_IMG_DEBUG} | ||
|
|
||
| # Build all amd64 docker images | ||
| PHONY: build-amd64 |
There was a problem hiding this comment.
should there be . PHONY instead?
cw-Guo
reviewed
Oct 31, 2025
| # Build arm64 Fluentd container image | ||
| .PHONY: build-fd-arm64 | ||
| build-fd-arm64: | ||
| docker build --platform=linux/arm64 -f cmd/fluent-watcher/fluentd/Dockerfile.amd64 . -t ${FD_IMG} |
There was a problem hiding this comment.
do we actually have the fluentd dockerfile for arm64 or amd64? only see cmd/fluent-watcher/fluentd/Dockerfile
There was a problem hiding this comment.
We use the same Dockerfile for both architectures.
There was a problem hiding this comment.
then should we change the path to cmd/fluent-watcher/fluentd/Dockerfile?
marcofranssen
force-pushed
the
chore/arm64-makefile-targets
branch
from
ca24dfc to
a82fa47
Compare
Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Co-authored-by: Marco Franssen <[email protected]> Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
marcofranssen
force-pushed
the
chore/arm64-makefile-targets
branch
from
a82fa47 to
484a96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
arm64make targets for building arm64 images locally.